Make the sync subtitle delay feature intuitive - #3160
Merged
fire-light42 merged 1 commit intoSep 23, 2026
Merged
fire-light42 merged 1 commit into
fire-light42 merged 1 commit into
Conversation
fire-light42
requested changes
Sep 13, 2026
fire-light42
left a comment
fire-light42
left a comment
Collaborator
There was a problem hiding this comment.
Great feature! I do agree that it is much more intuitive now!
However it seems like this pull request accidentally included additional code which changes subtitle groupings
Invert the sign convention of the player subtitle delay so the value in the offset dialog is the number of milliseconds the subtitles are shown too late (a lag), and a negative value means they are shown too early. - subtitleDelay no longer negates setSubtitleOffset/getSubtitleOffset, so the box value matches the decoder offset sign. The +/> and -/< buttons are unchanged, so each press now shifts playback the opposite way. - Swap the two hint format strings so the wording tracks the new sign (positive -> too late, negative -> too early). - Flip the sync-list position math and the row-tap handler to match the new offset sign. Generated with AI
refirestream
force-pushed
the
feature/subtitle-delay-too-early
branch
from
September 17, 2026 07:22
f573980 to
72a39c3
Compare
fire-light42
approved these changes
Sep 23, 2026
Contributor
Author
|
Thanks for merging ! And sorry about that mix-up with the accidentally included code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've always felt like this subtitle delay feature was counter intuitive, the + button on the right should actually make the white slider go forward (meaning that the subtitle was lagging too much behind the audio), as opposed to what is currently implemented.
This PR implements that.